Support Blacklight 8

[corylown]

This may have mostly been completed via https://github.com/projectblacklight/spotlight/pull/2853

Relates to:

• https://github.com/projectblacklight/spotlight/issues/3025
• https://github.com/projectblacklight/spotlight/issues/2950
• https://github.com/projectblacklight/spotlight/pull/2949
• https://github.com/projectblacklight/spotlight/pull/3022

Upgrading to Blacklight 8 Guide

• [ ] #3069
• [ ] https://github.com/projectblacklight/spotlight/issues/2966
• [ ] #3070
• [ ] https://github.com/projectblacklight/spotlight/pull/2922
• [ ] Convert admin partials to components? (not sure if this is strictly required): https://github.com/search?q=repo%3Aprojectblacklight%2Fspotlight+blacklight_config.view.admin_table&type=code
• [ ] Figure out if we need to adapt how we're handling constraints: see https://github.com/projectblacklight/blacklight/wiki/Upgrading-to-Blacklight-8#adding-elements-to-constraints and also: https://github.com/search?q=repo%3Aprojectblacklight%2Fspotlight+render_constraints&type=code

Things we can drop if we stop supporting Blacklight 7:

• [ ] Blacklight::SearchService#fetch returns just the documents, not the solr response and the documents: https://github.com/search?q=repo%3Aprojectblacklight%2Fspotlight+search_service.fetch&type=code
• [ ] convert_to_search_state has been removed. Just use search_state: https://github.com/search?q=repo%3Aprojectblacklight%2Fspotlight+convert_to_search_state&type=code

[corylown]

Known issues with Blacklight 8 & Spotlight:

• app/views/layouts/spotlight/base.html.erb and app/views/shared/_header_navbar.html.erb both call Blacklight's container_classes helper that in Blacklight 8 calls blacklight_config. Seeing some test failures complaining that blacklight_config is not defined.
• The only way I've been able to get spotlight to work with Blacklight 8 is to generate spotlight with Blacklight 7 and then switch to version 8 via the gemfile, likely due to different default settings for asset handling in BL7 vs 8.
• Had to add to app/assets/config/manifest.js

  //= link blacklight/manifest.js

• The public/private checkbox control in the items admin view is broken. When you click the checkbox you get an error: Unable to save the bookmark at this time
• The shared/flash_msg is complaining about blacklight_config being undefined.
• _solr_documents_features_block.html.erb is trying to use the truncate helper and I think it's weirdly finding the ActiveRecord::ConnectionAdapters::DatabaseStatements.truncate instead which has a different method signature.

[hudajkhan]

I will start picking up specific pieces of this issue. I'm not sure if we want the open tasks in the ready column as well but just indicating I am beginning to look at this. Starting with #3069

[corylown]

Thanks @hudajkhan! I think the work for this ticket is described by my Aug 7 comment. We know that Blacklight 8 mostly works with Spotlight 4 because DLME is on Blacklight 8. The goal here is mostly to get the tests passing and address any lingering incompatibilities. We can talk more after stand-up, but there are a few different approaches we could take as other work to get CI and the generators working with Blacklight 8.