Open corylown opened 2 months ago
Known issues with Blacklight 8 & Spotlight:
app/views/layouts/spotlight/base.html.erb
and app/views/shared/_header_navbar.html.erb
both call Blacklight's container_classes
helper that in Blacklight 8 calls blacklight_config
. Seeing some test failures complaining that blacklight_config
is not defined.app/assets/config/manifest.js
//= link blacklight/manifest.js
Unable to save the bookmark at this time
shared/flash_msg
is complaining about blacklight_config
being undefined._solr_documents_features_block.html.erb
is trying to use the truncate
helper and I think it's weirdly finding the ActiveRecord::ConnectionAdapters::DatabaseStatements.truncate
instead which has a different method signature.I will start picking up specific pieces of this issue. I'm not sure if we want the open tasks in the ready column as well but just indicating I am beginning to look at this. Starting with #3069
Thanks @hudajkhan! I think the work for this ticket is described by my Aug 7 comment. We know that Blacklight 8 mostly works with Spotlight 4 because DLME is on Blacklight 8. The goal here is mostly to get the tests passing and address any lingering incompatibilities. We can talk more after stand-up, but there are a few different approaches we could take as other work to get CI and the generators working with Blacklight 8.
This may have mostly been completed via https://github.com/projectblacklight/spotlight/pull/2853
Relates to:
Upgrading to Blacklight 8 Guide
Things we can drop if we stop supporting Blacklight 7:
Blacklight::SearchService#fetch
returns just the documents, not the solr response and the documents: https://github.com/search?q=repo%3Aprojectblacklight%2Fspotlight+search_service.fetch&type=codeconvert_to_search_state
has been removed. Just usesearch_state
: https://github.com/search?q=repo%3Aprojectblacklight%2Fspotlight+convert_to_search_state&type=code