search

projectblacklight / spotlight

Spotlight enables librarians, curators, and others who are responsible for digital collections to create attractive, feature-rich websites that highlight these collections.
Other
160 stars 64 forks source link

[WIP] Replace bootstrap-tagsinput with Tom Select #3074

Open taylor-steve opened 2 months ago

taylor-steve commented 2 months ago

Chasing seemingly unrelated test ghosts locally, let's see what CI says...

bootstrap-tagsinput is unsupported and out of date. Tom Select supports using a text input, has a similar method of loading remote data, and has both Bootstrap 4 and 5 assets. Vendoring the assets for now, but if we change the asset pipeline for Spotlight v4 perhaps we can remove that.

jcoyne commented 2 months ago

This seems like a huge addition for a small feature. Have you also considered adapting https://github.com/sul-dlss/argo/blob/main/app/javascript/controllers/text_extraction_controller.js ?

taylor-steve commented 2 months ago

It certainly looks huge. It's ~70 lines, 30 of which are config. The rest are vendor files because we lack a clean way to incorporate those in a different fashion (AFAIK).

I wasn't aware of that code, thanks.