projectbuendia / client

Android client app
Apache License 2.0
38 stars 23 forks source link

Represent patient sex as an enum, consistently named "sex" throughout. #442

Closed zestyping closed 5 years ago

zestyping commented 5 years ago

Issues: Scope: Patient and PatientDelta models Requested reviewers:

User-visible changes

Previously there was a bug where editing a patient with an unknown gender, without touching the gender options, would cause them to be saved as female. This bug is fixed.

Internal changes

We previously had "male" and "female" constants defined redundantly in multiple places, and the constants were integers. Now there is a single enum, and it is named Sex as it should be, instead of "gender". Terminology is changed to "sex" throughout the app.