projectbuendia / client

Android client app
Apache License 2.0
38 stars 23 forks source link

Fix the validation logic for the user, patient, and order dialogs #450

Closed zestyping closed 5 years ago

zestyping commented 5 years ago

Scope: New User dialog, New Patient dialog, Edit Patient dialog, Order dialog

User-visible changes

Validation was not working properly for these dialogs; entering invalid data would cause the dialog to disappear with no indication that invalid data was entered.

With this change, all the dialogs stay visible with an error message attached to the invalid field indicating what was wrong.

This includes validating that an ID is entered when adding a new patient.

As a crude fix for the problem of no visible feedback while a patient is being saved or updated, we pop a toast indicating that work is happening. The duration of the toast is fixed, though, and does not actually indicate when processing is finished.