Match the broadcast address before the 240.0.0.0/4 CIDR

projectcalico / bird

Calico's fork of the BIRD protocol stack

90 stars 86 forks source link

Match the broadcast address before the 240.0.0.0/4 CIDR #100

Closed gmavrikas closed 2 years ago

gmavrikas commented 2 years ago

Description

The check for the 240.0.0.0/4 CIDR was also matching the broadcast address 255.255.255.255 Moved the broadcast check above the 240.0.0.0/4 check

Release Note

Fix a bug where the check for treating the 240/4 CIDR like RFC 1918 ranges caught the broadcast address 255.255.255.255

CLAassistant commented 2 years ago

All committers have signed the CLA.

gmavrikas commented 2 years ago

The CLA link does not work for me (blank page). Any help?

gmavrikas commented 2 years ago

The CLA link does not work for me (blank page). Any help?

It now worked, accepted the CLA

caseydavenport commented 2 years ago

/sem-approve

nelljerram commented 2 years ago

Thanks @caseydavenport , LGTM too.

FYI, support for 240/4 has just been added to upstream BIRD master, so it might be in our interest to submit a backport of that to the upstream 1.6 branch, then merge that here, so as to reduce this fork's divergence from upstream 1.6.