nest/iface.c: Determine if the iface passed by the if_update() functi…

projectcalico / bird

Calico's fork of the BIRD protocol stack

90 stars 86 forks source link

nest/iface.c: Determine if the iface passed by the if_update() functi… #103

Closed dbfancier closed 2 years ago

dbfancier commented 2 years ago

…on is the one to delete, and if so, remove it from the iface_list (#102 )

Description

to solve the issue #102
After bird was running for some time, there were a large number of ifindex, MTU 0 entries, up to 40,000 in our production environment, which severely affected The CPU utilization of Bird
this affect kif_scan process

CLAassistant commented 2 years ago

All committers have signed the CLA.

caseydavenport commented 2 years ago

@dbfancier thanks for this PR - I will need to take some time to get up to speed on this code, but at a glance it appears to be a plausible fix.

caseydavenport commented 2 years ago

@dbfancier are you still working on this one?

splitice commented 2 years ago

@caseydavenport if you were to take over I don't think anyone would object.

Many people I know are being forced to kill bird regularly currently. It's a horrible solution that needs to be fixed.

splitice commented 2 years ago

@dbfancier @caseydavenport Any chance this could be given some time?

Its a serious issue (particularly for anyone doing cronjobs) that seems to be stalled.

mgleung commented 2 years ago

Hey @splitice , sorry for the delay, we're working on finding the right person to take this over so just wanted to let you know that it's on our radar.

dbfancier commented 1 year ago

@dbfancier are you still working on this one?

I am so sorry to see this message just now, thank you for your attention and fixing the problem . this modification worked well in our production environment, although it was only a temporary solution. I'm glad to give you some ideas.