[proto/device] Ignore addr updates on DOWN ifcs

[dilyevsky]

Description

Ignores netlink addr updates for interfaces that do not have UP admin state. Improves performance for kube-ipvs* interfaces with large number of addresses. Could be one of the reasons behind https://github.com/projectcalico/bird/issues/95 when kube-proxy IPVS mode is used:

[CLAassistant]

All committers have signed the CLA.

[caseydavenport]

I'm not sure I understand why this is needed. I believe we are already telling BIRD to ignore the kube-ipvs interface entirely in its configuration. Do you have any thoughts on this?

[caseydavenport]

Ah, just saw your comment here: https://github.com/projectcalico/bird/issues/95#issuecomment-1317223246

So I think you're saying we ignore it for "direct" but there are other protocols that we can't exclude it for.

[dilyevsky]

@caseydavenport yep, that's right. For device and direct protocols in particular there is no interface option where one could add exclusion regexes (although Bird manual says there is one for direct it doesn't appear to be present in the version that Calico is using).

[dilyevsky]

@caseydavenport hey, would you mind taking another look here?

[caseydavenport]

@dilyevsky sorry for the delay! Looking now

[caseydavenport]

/sem-approve