search

projectcalico / bird

Calico's fork of the BIRD protocol stack
90 stars 86 forks source link

Remove spammy debug log message for DOWN interfaces #113

Closed lbogdan closed 8 months ago

lbogdan commented 8 months ago

Fixes https://github.com/projectcalico/calico/issues/8378

This PR removes the debug log message introduced in [proto/device] Ignore addr updates on DOWN ifcs, that is very spammy in kube-proxy ipvs mode clusters because of the DOWN kube-ipvs0 interface, as reported in https://github.com/projectcalico/calico/issues/8378.

After this PR is merged, and the image built and pushed, we'll also need to update the calico/bird version / tag in https://github.com/projectcalico/calico/blob/a684f90bec0bc99ccade9424d2312ac641ffd3dd/metadata.mk#L28-L29 .

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

caseydavenport commented 8 months ago

/sem-approve

lbogdan commented 8 months ago

Can this be merged?

caseydavenport commented 8 months ago

yes, sorry! I suppose @marvin-tigera hasn't been updated to watch this repo for the merge-when-ready label. Was expecting an auto-merge...