projectcalico / bird

Calico's fork of the BIRD protocol stack
90 stars 86 forks source link

Make amd64 calico/bird image useful for testing as well as for holding BIRD binaries #76

Closed nelljerram closed 4 years ago

nelljerram commented 4 years ago

Currently (prior to this PR), the calico/bird container image is used only as an intermediate step towards the production of a deliverable calico/node container image. Specifically, we use the calico/bird container image just as a way to wrap and publish the various BIRD binaries (on multiple architectures):

Then the calico/node build process pulls that image and copies the BIRD binaries out of it to the right place in the calico/node image.

Now - especially with the recent dual ToR work - we need something to model a router that is not a Calico node, and it's convenient to use BIRD for that too, as we're familiar with its config and operation. I have built a container image for that purpose from a different Dockerfile than calico/bird, and published it as "neiljerram/birdy", but:

So, the last bullet is what this PR does. For simplicity, for amd64 only, because we only need to test on amd64.

I have tested successfully that:

nelljerram commented 4 years ago

@song-jiang

Just wondering once PR is merged, should we switch node k8st to use new image?

Yes I will make sure to do that. I believe there are 2 cases: