Open TheCubicleJockey opened 10 months ago
Am I good to make the PR?
@TheCubicleJockey right now, there is support for podLabels
: https://github.com/projectcalico/calico/blob/master/charts/tigera-operator/values.yaml#L49-L50
Would you propose a new field that is merged with podLabels
?
My use case is for the clusterrole to have a label. So, I could make one specifically for the clusterrole, but I figured most charts have a values.commonLabels
or a values.additionalLabels
as a more generally acceptable version that would fit most need and my needs.
If i am doing the work, i would like to help improve the chart in a way that you or your team might like it improved.
Yes, I think values.additionalLabels
seems like a a good way to spin this, SGTM!
Made a PR here
Expected Behavior
This chart improvement would allow the user to include a defined label in the value.yaml, and that label would be included in the kubernetes objects in metadata.label where allowed by kubernetes.
Current Behavior
Nothing like this is allowed in this chart.
Possible Solution
Anything that allows user defined labels in the kubernetes objects. Using something like commonLabels at the top level of the values file.
Steps to Reproduce (for bugs)
Context
Labels are good in kubernetes for organization and for some custom tools that read labels as a part of rule sets.
Your Environment