CLAassistant
commented
3 weeks ago
All committers have signed the CLA.
Closed tanujd11 closed 1 day ago
CLAassistant
commented
3 weeks ago
All committers have signed the CLA.
caseydavenport
commented
3 weeks ago @tanujd11 thanks for the PR - before we can do anything you'll need to sign the CLA in order to make the bot happy :pray:
tanujd11
commented
3 weeks ago Done @caseydavenport.
caseydavenport
commented
2 weeks ago /sem-approve
caseydavenport
commented
2 weeks ago @tanujd11 thanks for the PR! This looks pretty good to me - I left one comment, and I also think we should add unit tests for this scenario much like the original PR for LBs did.
caseydavenport
commented
6 days ago /sem-approve
marvin-tigera
commented
6 days ago Removing "merge-when-ready" label due to new commits
caseydavenport
commented
2 days ago /sem-approve
Description
Similar to https://github.com/projectcalico/calico/pull/6282 but for externalIP, I kind of ran into this and it would be great if externalIPs populated as single IP addresses stop advertising itself as global routes and only expose itself for services with externalTrafficPolicy as Cluster.
Related issues/PRs
Fixes https://github.com/projectcalico/calico/issues/7558
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.