Add setNodeNetworkUnavailable option for calico node

yuzhiquan commented 1 week ago

Description

New feature, add an option setNodeNetworkUnavailable, default is true, control the behavior after calico-node is ready and the calico node to set NodeNetworkUnavailable = false or not. Some times, in our cluster, we have noticed that the node is ready and NodeNetworkUnavailable = false. but our network is not ready to accept the requests, so we want to add this option to control this. And we also can find the options in other network projects like flannel or cilium.

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Add setNodeNetworkUnavailable option for calico node

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

CLAassistant commented 1 week ago

All committers have signed the CLA.

caseydavenport commented 6 days ago

but our network is not ready to accept the requests, so we want to add this option to control this.

Out of curiosity, could you provide a bit more context for this? Is it Calico that is unable to accept requests or something else in the network?

How do you plan to configure this CLI flag - I don't think there's a way currently to set this when installing e.g., via the operator?

yuzhiquan commented 3 days ago

Is it Calico that is unable to accept requests or something else in the network?

We believe the root cause is the number of our nodes has achieved the quota of full-mesh mode, so we have plan to enable RR in the future, this pr just wants to give another choice in this condition, we can mark the node as ready when we make sure the network is ready for receive requests.

How do you plan to configure this CLI flag - I don't think there's a way currently to set this when installing e.g., via the operator?

Sorry, I'm not familiar with this part. Do you have any suggestions?

projectcalico / calico