search

projectcalico / networking-calico

Calico integration with OpenStack (Neutron)
7 stars 15 forks source link

mech_calico: Ignore pre-live-migration messages #38

Closed tj90241 closed 3 years ago

tj90241 commented 3 years ago

As of OpenStack Newton, an RPC call push was added to pre- live-migration steps. Reference PRs: https://review.opendev.org/c/openstack/nova/+/275073 https://review.openstack.org/#/c/260738/

This commit adds a guard to mech_calico's port updating logic so that it effectively ignores the pre-live-migration notification referenced above. Without this guard, mech_calico mistakeningly thinks the port is becoming unbound/disabled (and later enabled again) as part of the pre-live-migration notifications and flaps the VM's port accordingly.

In short, the addition of the guard is required to avoid an unconditional, intermittent loss of connectivity for VMs during the live-migration process.

Signed-off-by: Tyler Stachecki tstachecki@bloomberg.net

nelljerram commented 3 years ago

I've manually checked that I see these pre-migration updates in Tigera's own live migration testing, and am happy in principle that it will be OK (and in fact better) to skip them.

I've kicked off a full system test run - sadly not visible outside Tigera - at https://wavetank.tigera.io/view/Openstack/job/os-ms-fv-openstack-uussuri/43/ using https://launchpad.net/~project-calico/+archive/ubuntu/testing2, which was built from this PR.

nelljerram commented 3 years ago

/sem-approve

nelljerram commented 3 years ago

/sem-approve

nelljerram commented 3 years ago

Packages are ready so I've kicked off ST at https://wavetank.tigera.io/view/Openstack/job/os-ms-fv-openstack-uussuri/44/. It takes a few hours so I'll check the results on Monday morning.

nelljerram commented 3 years ago

ST passed, so I will merge this change now.