projectcalico / networking-calico

Calico integration with OpenStack (Neutron)
7 stars 15 forks source link

Remove PEP8 test as it's broken and we have no requirement for it now #40

Closed nelljerram closed 3 years ago

nelljerram commented 3 years ago

I was seeing the error described here - https://github.com/PyCQA/pyflakes/issues/367 - when running 'tox' locally on my own laptop.

That issue indicates that the issue has been fixed upstream, but my tox environment for some reason has these pins:

flake8==2.2.4
pyflakes==0.8.1

I guess hardcoded from within 'tox'?

Anyway, we actually have no requirement to conform to PEP8, so the simplest thing is just to remove PEP8 testing.

nelljerram commented 3 years ago

This has already been reviewed as part of #36 . I'm separating it out here so that I can merge it to fix CI and enable testing #38, which I may want to merge before #36.