search

projectcaluma / caluma

A collaborative form editing service
https://caluma.io/
GNU General Public License v3.0
67 stars 26 forks source link

Move closer to upstream ClientIDMutation #1081

Open sbor23 opened 4 years ago

sbor23 commented 4 years ago

Our Mutation is a homebrew solution to fix some issues with the graphene-django ClientIDMutation. Now I don't know all the background of this, but https://github.com/projectcaluma/caluma/pull/985 shows that we are running into issues with this now, because it seems like the SaveDocumentInput InputType doesn't know about the id which is passed. See https://travis-ci.com/github/projectcaluma/caluma/jobs/343595361#L2099

The Mutation links three upstream issues that led to the custom implementation: https://github.com/projectcaluma/caluma/blob/master/caluma/caluma_core/mutation.py#L79

Should be considered a show-stopper for https://github.com/projectcaluma/caluma/issues/814

Who knows enough about the graphene internals to tackle this?

sbor23 commented 4 years ago

It's not as grave is I feared, the specific issue we're facing is tracked here: https://github.com/graphql-python/graphene-django/issues/906

But we should still consider trying to upstream the changes mentioned in said docstrings, the issues on graphene-django are all stale although solutions have been posted.