projectcaluma / ember-caluma

Ember.js addons for Caluma
https://docs.caluma.io/ember-caluma/
GNU Lesser General Public License v3.0
18 stars 22 forks source link

bug: scss import of ember-uikit/variables-theme fails #2378

Closed derrabauke closed 1 year ago

derrabauke commented 1 year ago

While upgrading ember-uikit to v7.0.2 in our application, we get an error with ember-caluma trying to import ember-uikit/variables-theme.

Sass Syntax Error (SassCompiler) in /tmp/broccoli-386687qSLemuEE93xz/out-1547-funnel_funnel_styles//app/styles/@projectcaluma/ember-form.scss:1:9

Error: Can't find stylesheet to import.
  ╷
1 │ @import "ember-uikit/variables-theme";
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  /tmp/broccoli-386687qSLemuEE93xz/out-1547-funnel_funnel_styles/app/styles/@projectcaluma/ember-form.scss 1:9  @import
  /tmp/broccoli-386687qSLemuEE93xz/out-1547-funnel_funnel_styles/app/styles/app.scss 15:9                       root stylesheet

Stack Trace and Error Report: /tmp/error.dump.cc482bcaf099c575478ec062991d9656.log

After the latest fix of ember-uikit, I guess the following line https://github.com/projectcaluma/ember-caluma/blob/5a8217ed570cf55ea2076065526e0a264a7ff603/packages/form/app/styles/%40projectcaluma/ember-form.scss#L1

should be replaced by.

@import "ember-uikit";
anehx commented 1 year ago

I don't think this is an issue of @projectcaluma/ember-form but an issue of the host app because multiple versions of ember-uikit are installed (because #2377 is not merged and released yet). Have you tried adding a resolution for ember-uikit?

czosel commented 1 year ago

I agree @anehx - unfortunately the resolution for ember-uikit doesn't seem to help. Ping me if you have a second to look at this together.

czosel commented 1 year ago

Solved in https://github.com/adfinis/ember-uikit/pull/1050