projectcaluma / ember-caluma

Ember.js addons for Caluma
https://docs.caluma.io/ember-caluma/
GNU Lesser General Public License v3.0
18 stars 22 forks source link

Flakey test in ember-form #2514

Closed Yelinz closed 8 months ago

Yelinz commented 1 year ago

Sometimes fails, retry of test passes

not ok 29 Chrome 116.0 - [101 ms] - Integration | Component | cf-field/input/action-button: validates as configured
    ---
        actual: >

        expected: >
            validate
        stack: >
                at Assert.verifySteps (webpack://__ember_auto_import__/../../node_modules/.pnpm/qunit@2.19.4/node_modules/qunit/qunit/qunit.js?:283:51)
        negative: >
            false
        browser log: |
    ...

https://github.com/projectcaluma/ember-caluma/actions/runs/6170568375/job/16747149151 https://github.com/projectcaluma/ember-caluma/actions/runs/6183695072/job/16785971723

derrabauke commented 10 months ago

:heavy_plus_sign: that

Yelinz commented 8 months ago

Only fails on chrome, have never gotten it to fail on firefox. Maybe we should just remove this test step (validate on enter), as the functionality is already being tested multiple times in other tests. For example https://github.com/projectcaluma/ember-caluma/blob/ebcd822c65b8639f6449a702e74a8129f14f718d/packages/form/tests/integration/components/document-validity-test.js#L34-L54

Any opinion @anehx @derrabauke

anehx commented 8 months ago

@Yelinz yeah, let's remove it so our pipelines have meaning again..

anehx commented 8 months ago

:tada: This issue has been resolved in version 12.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: