search

projectcaluma / ember-caluma

Ember.js addons for Caluma
https://docs.caluma.io/ember-caluma/
GNU Lesser General Public License v3.0
18 stars 22 forks source link

fix(translations): change "optional" to "optionnelle" #2689

Closed StephanH90 closed 2 months ago

StephanH90 commented 2 months ago

Description

Changes "optional" in French to "optionnelle". That is, according to one of our French speaking clients, the correct translation.

amchangama commented 2 months ago

optionnelle is the feminine, using optionnel (masculin) is common if we are not sure of what were refering to(either feminine or masculine)

anehx commented 2 months ago

optionnelle is the feminine, using optionnel (masculin) is common if we are not sure of what were refering to(either feminine or masculine)

In this case "optional" refers to the question which is a feminine word: https://dictionnaire.lerobert.com/definition/question

So IMO this change is correct, right @amchangama ?

amchangama commented 2 months ago

@anehx yes it is correct if it refers to a question

anehx commented 2 months ago

:tada: This PR is included in version 12.11.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: