search

projectcaluma / ember-caluma

Ember.js addons for Caluma
https://docs.caluma.io/ember-caluma/
GNU Lesser General Public License v3.0
18 stars 22 forks source link

chore(form): add missing sass dev dependencies #2699

Closed Yelinz closed 3 weeks ago

Yelinz commented 2 months ago

Description

dependents seem to have problems with importing the form styles (errors with not found), but not analytics or others. The difference I spotted between was form not having sass as any dependency.

anehx commented 2 months ago

Pretty sure that having additional devDependencies will do anything as host apps don't know about those..

Yelinz commented 2 months ago

Pretty sure that having additional devDependencies will do anything as host apps don't know about those..

Yea, I know, but just saw they were missing while having scss styles. Can be considered just a consistency improvement

anehx commented 2 months ago

Can be considered just a consistency improvement

Fair enough, then I'd categorize this as chore instead of a fix.

Yelinz commented 2 months ago

Its a flakey modal, cannot reproduce it consistently locally. Will look into it a bit more tests fixed

anehx commented 2 weeks ago

:tada: This PR is included in version 12.15.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: