projectcaluma / ember-caluma

Ember.js addons for Caluma
https://docs.caluma.io/ember-caluma/
GNU Lesser General Public License v3.0
18 stars 22 forks source link

feat(form): add case infos to jexl context #2703

Closed czosel closed 1 month ago

czosel commented 2 months ago

This is convenient when you'd like to write a JEXL expression in a task form attached to some work item, that depends on the case's main documents' form.

Related backend MRs:

StephanH90 commented 2 months ago

Don't forget to rename the property once a decision is made but I will approve now.

StephanH90 commented 2 months ago

But the naming between the backend and the frontend doesn't match, does it?

In the backend we now have a main_case_form which would be the case.root.form in the frontend, correct? (https://github.com/projectcaluma/caluma/pull/2204/files#diff-4200093d628340ea25db028f99d1543cb5c63af275a4a670a9c08adee6444effR150-R158)

Should we try to keep the naming consistent between frontend and backend?

czosel commented 2 months ago

But the naming between the backend and the frontend doesn't match, does it?

In the backend we now have a main_case_form which would be the case.root.form in the frontend, correct? (https://github.com/projectcaluma/caluma/pull/2204/files#diff-4200093d628340ea25db028f99d1543cb5c63af275a4a670a9c08adee6444effR150-R158)

Should we try to keep the naming consistent between frontend and backend?

The backend MR was merged a little bit too quickly, here is the follow-up which should line up with the frontend part: https://github.com/projectcaluma/caluma/pull/2205

czosel commented 1 month ago

@anehx I added another test for unlinked documents. Want to take another look?

anehx commented 1 month ago

:tada: This PR is included in version 12.15.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: