search

projectcaluma / ember-caluma

Ember.js addons for Caluma
https://docs.caluma.io/ember-caluma/
GNU Lesser General Public License v3.0
18 stars 22 forks source link

fix(distribution): remove suggestions from types and defaultTypes #2723

Closed StephanH90 closed 1 month ago

StephanH90 commented 1 month ago

Description

Because we merge the default options with any custom supplied options, it is impossible to hide the suggestions from the distribution. One of our customers has the situation where a given service should not see the suggestions because they would always be empty for them.

Because I remove something from the default, this change is potentially breaking.

anehx commented 1 month ago

Yes there is an option: 

types: {
  suggestions: {
    disabled: true
  }
}
StephanH90 commented 1 month ago

But if we didn't add the suggestions by default by deepmerging the settings, we wouldn't even need this option?