search

projectcapsule / capsule

Multi-tenancy and policy-based framework for Kubernetes.
https://capsule.clastix.io
Apache License 2.0
1.57k stars 155 forks source link

chore(helm): make capsule configuration name configurable via helm #1103

Closed sybnex closed 3 months ago

sybnex commented 3 months ago

As this is fixed in the helm templates we need a very hacky implementation to change this value.

We have like 150 groups which we are creating in a new configuration. So I suggest to make this configuration templated as well.

netlify[bot] commented 3 months ago

Deploy Preview for capsule-documentation canceled.

Name Link
Latest commit 3720989107a07afad4c3217583dfee2ac46268d8
Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/667027719b1e6500084f5029
prometherion commented 3 months ago

LGTM, may I ask you to amend the commits with the DCO and change the Pull Request title to feat(helm): capsuleconfiguration name configurable?

Thanks!

sybnex commented 3 months ago

LGTM, may I ask you to amend the commits with the DCO and change the Pull Request title to feat(helm): capsuleconfiguration name configurable?

Thanks!

I tried to, but this DCO ... seems to make trouble? I'm lost here, sorry.

maxgio92 commented 3 months ago

Hi @sybnex I got the problem, and I fixed.

JFI The current version of the DCO uses a version of Git that removed the dot ('.') considering it an invalid trailing crud character (commit). But I see you're using likely a Git version > 2.42, as the period is in your author name in your commit, so the check while not matching the author names, wasn't passing.

Thanks

maxgio92 commented 3 months ago

Hi @sybnex, may I ask you to update the chart documentation? I.e.:

+| manager.options.capsuleConfiguration | string | `"default"` | Change the default name of the capsule configuration name |

You should be able to do it just by running make helm-docs from the root of the repository.

Overall LGTM