search

projectchrono / chrono

High-performance C++ library for multiphysics and multibody dynamics simulations
http://projectchrono.org
BSD 3-Clause "New" or "Revised" License
2.2k stars 461 forks source link

ChFunctionRecorder (ChFunction_Recorder) deleted #505

Closed cekees closed 2 months ago

cekees commented 3 months ago

Hi. We have code that depends on using ChFunctionRecorder, but it appears to have been deleted in the commit below. Was that intentional? I'll disable this use case for now.

commit 95f51042a4b597fb96297e1e5210e2b52075e32f Author: DarioMangoni dariomangoni@gmail.com Date: Tue Mar 19 17:00:04 2024 +0100

Merge branch 'feature/overhaul' into feature/modal_projection

# Conflicts:
#       src/chrono_modal/ChEigenvalueSolver.cpp
#       src/chrono_modal/ChKrylovSchurEig.cpp
#       src/chrono_modal/ChModalAssembly.cpp
#       src/chrono_modal/ChModalAssembly.h
#       src/chrono_modal/ChModalDamping.cpp
#       src/chrono_modal/ChModalDamping.h
#       src/demos/modal/demo_MOD_modal_assembly.cpp
rserban commented 3 months ago

Chris - there was a large API refactoring that happened before the 9.0 release. All changes are documented in the CHANGELOG.

In particular, the class you mentioned (ChFunction_Recorder) was not deleted, but rather renamed to ChFunctionInterp.

cekees commented 2 months ago

Thanks!