search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

CI: add uncommitted codegen check #385

Closed skriss closed 3 years ago

skriss commented 3 years ago

Adds a CI check that runs all code generation Make tasks and then errors if there are any uncommitted changes, meaning the PR should've updated generated code but did not.

Closes #384.

Signed-off-by: Steve Kriss krisss@vmware.com

skriss commented 3 years ago

Note that this is currently failing (https://github.com/projectcontour/contour-operator/pull/385/checks?check_run_id=2823427358) because it's detecting https://github.com/projectcontour/contour-operator/pull/373#discussion_r650566073.

codecov[bot] commented 3 years ago

Codecov Report

Merging #385 (e8a80c3) into main (e4f4721) will decrease coverage by 0.10%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   59.49%   59.39%   -0.11%     
==========================================
  Files          19       19              
  Lines        1879     1879              
==========================================
- Hits         1118     1116       -2     
- Misses        735      736       +1     
- Partials       26       27       +1
Impacted Files Coverage Δ
pkg/validation/validation.go 81.42% <0.00%> (-1.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4f4721...e8a80c3. Read the comment docs.

skriss commented 3 years ago

Looks like things were still out-of-date so I've added https://github.com/projectcontour/contour-operator/pull/385/commits/e8a80c39c2e35dda346592e6756b05516ddf8868 to update the generated code which should make this PR pass.