Fixes for Contour now reconciling GatewayClasses and Gateways

[sunjayBhatia]

Now that Contour reconciles and sets status on GatewayClass and Gateway resources, this is the first step to clean up the operator to remove bits that conflict with Contour itself.

• Pass controller name string to Contour in ConfigMap to ensure Contour is properly configured for Gateway API
• Remove status updating/checking on Gateway API resources
  • Don't set GatewayClass status or expect it to be admitted by Operator
  • Don't set Gateway status or expect it to be set in tests
  • When reconciling Contour CRD, do not check if referenced GatewayClass is admitted
• Adds test to make sure multiple Contours with Gateway API work
  • Currently this is a bit broken and not how Gateway API should work
  • Due to the fact that the Operator only reconciles 1 GatewayClass and passes that along to Contour
  • This will be cleaned up in next release

Fixes: #400

[codecov[bot]]

Codecov Report

Merging #401 (524b13b) into main (b8fe3a3) will increase coverage by 3.05%. The diff coverage is 75.00%.

:exclamation: Current head 524b13b differs from pull request most recent head 3ed66ae. Consider uploading reports for the commit 3ed66ae to get more accurate results

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   59.22%   62.27%   +3.05%     
==========================================
  Files          19       19              
  Lines        2065     1914     -151     
==========================================
- Hits         1223     1192      -31     
+ Misses        815      695     -120     
  Partials       27       27              

Impacted Files	Coverage Δ
internal/operator/status/status.go	0.00% <0.00%> (ø)
pkg/validation/validation.go	82.50% <ø> (-1.23%)	:arrow_down:
internal/objects/configmap/configmap.go	34.93% <100.00%> (+0.79%)	:arrow_up:
internal/operator/status/conditions.go	65.38% <100.00%> (+16.41%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8fe3a3...3ed66ae. Read the comment docs.

[sunjayBhatia]

All green besides the codecov check on the patch diff

[sunjayBhatia]

@skriss @youngnick this one is ready for review and should fix Operator CI

[skriss]

Other than the thread about ways to support >1 Gateway-enabled Contour, this looks OK to me - I tried a basic test out locally and everything seemed to work.

[sunjayBhatia]

@skriss @stevesloka @youngnick when you get a chance to review officially I think this should fix operator CI at least for 1.18

I'll open up some issues for what we need to do for the next release

[sunjayBhatia]

release note should mention that the operator will no longer set status on GatewayClass/Gateways

[skriss]

woohoo ✅

[skriss]

@stevesloka if you have a chance to review it'd be great to get this in so we can get the other PRs for 1.18 in too.