Codecov Report

Merging #404 (37820a4) into main (48b33e8) will decrease coverage by 2.77%. The diff coverage is n/a.

:exclamation: Current head 37820a4 differs from pull request most recent head 83e18ff. Consider uploading reports for the commit 83e18ff to get more accurate results

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   62.27%   59.49%   -2.78%     
==========================================
  Files          19       19              
  Lines        1914     1879      -35     
==========================================
- Hits         1192     1118      -74     
- Misses        695      735      +40     
+ Partials       27       26       -1

Impacted Files	Coverage Δ
pkg/validation/validation.go	`82.85% <ø> (+0.35%)`	:arrow_up:
internal/operator/scheme.go	`11.11% <0.00%> (-16.17%)`	:arrow_down:
pkg/labels/labels.go	`66.66% <0.00%> (-8.34%)`	:arrow_down:
...objects/clusterrolebinding/cluster_role_binding.go	`38.63% <0.00%> (-2.88%)`	:arrow_down:
internal/operator/operator.go	`70.00% <0.00%> (-2.73%)`	:arrow_down:
internal/objects/configmap/configmap.go	`32.39% <0.00%> (-2.55%)`	:arrow_down:
internal/parse/parse.go	`16.00% <0.00%> (-0.67%)`	:arrow_down:
internal/objects/clusterrole/cluster_role.go	`70.40% <0.00%> (-0.13%)`	:arrow_down:
internal/retryableerror/retryableerror.go	`100.00% <0.00%> (ø)`
internal/status/status.go
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48b33e8...83e18ff. Read the comment docs.

nak3 commented 3 years ago

Friendly ping @skriss @youngnick I am looking forward to this.

dprotaso commented 3 years ago

@skriss you might have to re-run the checks - I'm not able to do that

skriss commented 3 years ago

@dprotaso main is back to green, if you could rebase here we should be good to go

dprotaso commented 3 years ago

@skriss rebased

skriss commented 3 years ago

thanks @dprotaso!

projectcontour / contour-operator

Revert "Adds IngressClassName Validation (#388)" #404

Codecov Report