search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

internal: move config, controller, status packages #410

Closed skriss closed 3 years ago

skriss commented 3 years ago

Moves these three packages up one level, from under internal/operator/ to directly under internal/. This simplifies the package hierarchy.

Signed-off-by: Steve Kriss krisss@vmware.com

skriss commented 3 years ago

@stevesloka @youngnick @sunjayBhatia let me know if this seems like a reasonable change. Just looking to ramp back up on the operator and simplify some things where possible. Can definitely hold merging this until after any gateway-related changes, to avoid conflicts.

codecov[bot] commented 3 years ago

Codecov Report

Merging #410 (b8c1801) into main (5cbf8e2) will decrease coverage by 3.05%. The diff coverage is n/a.

:exclamation: Current head b8c1801 differs from pull request most recent head 4c6b672. Consider uploading reports for the commit 4c6b672 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   62.27%   59.22%   -3.06%     
==========================================
  Files          19       19              
  Lines        1914     2065     +151     
==========================================
+ Hits         1192     1223      +31     
- Misses        695      815     +120     
  Partials       27       27
Impacted Files Coverage Δ
internal/objects/job/job.go 53.04% <ø> (ø)
internal/operator/operator.go 72.72% <ø> (ø)
internal/status/conditions.go 48.96% <ø> (ø)
internal/status/status.go 0.00% <ø> (ø)
internal/objects/configmap/configmap.go 34.14% <0.00%> (-0.80%) :arrow_down:
pkg/validation/validation.go 83.72% <0.00%> (+1.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cbf8e2...4c6b672. Read the comment docs.

sunjayBhatia commented 3 years ago

@stevesloka @youngnick @sunjayBhatia let me know if this seems like a reasonable change. Just looking to ramp back up on the operator and simplify some things where possible. Can definitely hold merging this until after any gateway-related changes, to avoid conflicts.

sounds good to me, no need to have duplication/extra in the package paths if we dont need it

skriss commented 3 years ago

doesn't look like this should cause conflicts for other PRs now, ready for review/merge