Closed sunjayBhatia closed 3 years ago
Merging #416 (4b5bcf4) into main (67ec0cf) will decrease coverage by
2.77%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 72.03% 69.25% -2.78%
==========================================
Files 35 35
Lines 2700 2700
==========================================
- Hits 1945 1870 -75
- Misses 609 668 +59
- Partials 146 162 +16
Impacted Files | Coverage Δ | |
---|---|---|
internal/objects/contour/finalizer.go | 62.50% <0.00%> (-18.75%) |
:arrow_down: |
internal/controller/contour/controller.go | 52.59% <0.00%> (-17.54%) |
:arrow_down: |
internal/status/status.go | 43.24% <0.00%> (-16.22%) |
:arrow_down: |
internal/status/conditions.go | 69.23% <0.00%> (-7.70%) |
:arrow_down: |
internal/controller/gatewayclass/controller.go | 57.14% <0.00%> (-7.15%) |
:arrow_down: |
internal/objects/rbac.go | 54.76% <0.00%> (-5.96%) |
:arrow_down: |
internal/objects/namespace/namespace.go | 61.66% <0.00%> (-5.00%) |
:arrow_down: |
internal/objects/configmap/configmap.go | 72.28% <0.00%> (-3.62%) |
:arrow_down: |
internal/objects/contour/contour.go | 79.06% <0.00%> (-3.49%) |
:arrow_down: |
internal/objects/service/service.go | 83.47% <0.00%> (-2.61%) |
:arrow_down: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 67ec0cf...4b5bcf4. Read the comment docs.
gonna merge with powers, its a small change
Also use timeout specificly for waiting for Contour, not general timeout
Fixes: #415