search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

fixes for test-example #417

Closed skriss closed 3 years ago

skriss commented 3 years ago

In test-example, deletes Gateway API resources in the expected order to avoid race conditions with finalizers that lead to test flakes. Also adds a 30-minute timeout to the GitHub Actions job.

Signed-off-by: Steve Kriss krisss@vmware.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #417 (71baada) into main (eb83afd) will decrease coverage by 2.92%. The diff coverage is n/a.

:exclamation: Current head 71baada differs from pull request most recent head c94c39d. Consider uploading reports for the commit c94c39d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   72.14%   69.22%   -2.93%     
==========================================
  Files          35       35              
  Lines        2700     2700              
==========================================
- Hits         1948     1869      -79     
- Misses        605      674      +69     
- Partials      147      157      +10
Impacted Files Coverage Δ
internal/status/status.go 43.24% <0.00%> (-32.44%) :arrow_down:
internal/controller/gatewayclass/controller.go 46.42% <0.00%> (-17.86%) :arrow_down:
internal/controller/contour/controller.go 53.89% <0.00%> (-14.29%) :arrow_down:
internal/status/conditions.go 69.23% <0.00%> (-7.70%) :arrow_down:
internal/objects/rbac.go 54.76% <0.00%> (-5.96%) :arrow_down:
internal/objects/namespace/namespace.go 61.66% <0.00%> (-5.00%) :arrow_down:
internal/objects/configmap/configmap.go 72.28% <0.00%> (-3.62%) :arrow_down:
internal/objects/contour/contour.go 79.06% <0.00%> (-3.49%) :arrow_down:
internal/objects/service/service.go 83.47% <0.00%> (-2.61%) :arrow_down:
internal/objects/job/job.go 76.52% <0.00%> (-2.61%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb83afd...c94c39d. Read the comment docs.