search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

test/e2e: add a timeout to HTTP client #418

Closed skriss closed 3 years ago

skriss commented 3 years ago

Adds a 5-second timeout to the HTTP client to prevent requests from hanging forever. Requests are wrapped in a retry loop so timed-out requests will be retried.

Signed-off-by: Steve Kriss krisss@vmware.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #418 (77982e6) into main (55ff9bf) will decrease coverage by 0.70%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   71.74%   71.03%   -0.71%     
==========================================
  Files          35       35              
  Lines        2700     2700              
==========================================
- Hits         1937     1918      -19     
- Misses        613      635      +22     
+ Partials      150      147       -3
Impacted Files Coverage Δ
internal/controller/contour/controller.go 57.14% <0.00%> (-9.75%) :arrow_down:
internal/objects/gateway/gateway.go 32.75% <0.00%> (-3.45%) :arrow_down:
internal/objects/contour/contour.go 80.23% <0.00%> (-2.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55ff9bf...77982e6. Read the comment docs.

skriss commented 3 years ago

I believe this will address the issue encountered in https://github.com/projectcontour/contour-operator/runs/3185067010?check_suite_focus=true#step:5:310