Closed sunjayBhatia closed 3 years ago
Merging #420 (872bf85) into main (60e06bc) will increase coverage by
1.96%
. The diff coverage is65.21%
.:exclamation: Current head 872bf85 differs from pull request most recent head 26970ab. Consider uploading reports for the commit 26970ab to get more accurate results
@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 72.48% 74.44% +1.96%
==========================================
Files 35 35
Lines 2700 2704 +4
==========================================
+ Hits 1957 2013 +56
+ Misses 598 531 -67
- Partials 145 160 +15
Impacted Files | Coverage Δ | |
---|---|---|
cmd/contour-operator.go | 0.00% <0.00%> (ø) |
|
internal/objects/namespace/namespace.go | 65.00% <33.33%> (-1.67%) |
:arrow_down: |
internal/operator/operator.go | 75.64% <88.88%> (+2.91%) |
:arrow_up: |
internal/controller/contour/controller.go | 58.59% <100.00%> (-11.54%) |
:arrow_down: |
internal/status/status.go | 59.45% <0.00%> (-24.33%) |
:arrow_down: |
internal/objects/contour/finalizer.go | 62.50% <0.00%> (-18.75%) |
:arrow_down: |
internal/objects/gateway/gateway.go | 32.75% <0.00%> (-3.45%) |
:arrow_down: |
internal/objects/rbac.go | 58.33% <0.00%> (-2.39%) |
:arrow_down: |
internal/objects/configmap/configmap.go | 74.69% <0.00%> (-1.21%) |
:arrow_down: |
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 60e06bc...26970ab. Read the comment docs.
This change should put us in a better place once we start moving parts of Contour and the Operator around.
We can lean more heavily on this test suite rather than the e2e test suite since it should be faster to run/write etc.
This code probably duplicates some things from the e2e suite and things from that suite could be brought into here to run faster and with less flakes. Those should be future changes after this starting point.
Signed-off-by: Sunjay Bhatia sunjayb@vmware.com