search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

Add time limit to example test curl #424

Closed sunjayBhatia closed 3 years ago

sunjayBhatia commented 3 years ago

Also refactor so both tests actually have to pass not just the second one

Fixes: #419

codecov[bot] commented 3 years ago

Codecov Report

Merging #424 (91a4010) into main (d094fc6) will decrease coverage by 0.76%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   76.88%   76.12%   -0.77%     
==========================================
  Files          29       29              
  Lines        2228     2228              
==========================================
- Hits         1713     1696      -17     
- Misses        382      392      +10     
- Partials      133      140       +7
Impacted Files Coverage Δ
internal/status/status.go 51.35% <0.00%> (-10.82%) :arrow_down:
internal/controller/controller.go 65.57% <0.00%> (-9.02%) :arrow_down:
internal/objects/service/service.go 83.47% <0.00%> (-0.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d094fc6...91a4010. Read the comment docs.

stevesloka commented 3 years ago

Does this need #422 to work?

sunjayBhatia commented 3 years ago

Does this need #422 to work?

nope should be totally independent well maybe yeah, since we've removed the gateway stuff, CI generally is broken at the moment without #422

sunjayBhatia commented 3 years ago

using powers to merge for CI cleanliness