search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

Remove strange number `|2` in configmap #427

Closed nak3 closed 3 years ago

nak3 commented 3 years ago

Contour operator creates configmap with the strange contour.yaml: |2 as below:

$ kubectl get cm -n projectcontour contour -o yaml
apiVersion: v1
data:
  contour.yaml: |2

    #
    # server:
    #   determine which XDS Server implementation to utilize in Contour.
    #   xds-server-type: contour

Actually |2 is valid yaml but it makes confused.

This patch fixes it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #427 (ca8c2eb) into main (898379e) will decrease coverage by 0.40%. The diff coverage is n/a.

:exclamation: Current head ca8c2eb differs from pull request most recent head d004cec. Consider uploading reports for the commit d004cec to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   77.27%   76.86%   -0.41%     
==========================================
  Files          29       29              
  Lines        2222     2222              
==========================================
- Hits         1717     1708       -9     
- Misses        372      380       +8     
- Partials      133      134       +1
Impacted Files Coverage Δ
internal/objects/configmap/configmap.go 70.12% <ø> (ø)
internal/status/status.go 48.64% <0.00%> (-24.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 898379e...d004cec. Read the comment docs.