Closed skriss closed 3 years ago
Merging #431 (85454b9) into release-1.18 (a709974) will decrease coverage by
0.19%
. The diff coverage is100.00%
.:exclamation: Current head 85454b9 differs from pull request most recent head f41c3fd. Consider uploading reports for the commit f41c3fd to get more accurate results
@@ Coverage Diff @@
## release-1.18 #431 +/- ##
================================================
- Coverage 71.37% 71.17% -0.20%
================================================
Files 35 35
Lines 2700 2713 +13
================================================
+ Hits 1927 1931 +4
- Misses 630 635 +5
- Partials 143 147 +4
Impacted Files | Coverage Δ | |
---|---|---|
internal/config/config.go | 100.00% <ø> (ø) |
|
internal/objects/daemonset/daemonset.go | 94.28% <100.00%> (+0.27%) |
:arrow_up: |
internal/objects/contour/finalizer.go | 62.50% <0.00%> (-18.75%) |
:arrow_down: |
internal/objects/gateway/gateway.go | 32.75% <0.00%> (-3.45%) |
:arrow_down: |
internal/objects/contour/contour.go | 80.23% <0.00%> (-2.33%) |
:arrow_down: |
internal/controller/contour/controller.go | 57.14% <0.00%> (-1.30%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a709974...f41c3fd. Read the comment docs.
Hmm, codegen failing because it's trying to pull Contour's main
CRD YAML (which has changed). It should be looking at 1.18 YAML (which hasn't changed). Can ignore for now and follow up with a fix, I think.
Cherry-pick of #430:
Adds the envoy-admin emptyDir volume to the Envoy daemon set and updates the Envoy version to 1.19.1 to match projectcontour/contour.
Signed-off-by: Steve Kriss krisss@vmware.com