codegen CI check can fail on release branches

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour

Apache License 2.0

43 stars 34 forks source link

codegen CI check can fail on release branches #432

Open skriss opened 3 years ago

skriss commented 3 years ago

Hmm, codegen failing because it's trying to pull Contour's main CRD YAML (which has changed). It should be looking at 1.18 YAML (which hasn't changed). Can ignore for now and follow up with a fix, I think.

Originally posted by @skriss in https://github.com/projectcontour/contour-operator/issues/431#issuecomment-906499939

skriss commented 3 years ago

On release branches, https://github.com/projectcontour/contour-operator/blob/main/Makefile#L147-L151 has NEW_VERSION set to main, so it's pulling the main version of projectcontour/contour's CRD YAML instead of the release-branch-relevant version.