projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

Option to configure `enableExternalNameService` #437

Closed krsna-m closed 3 years ago

krsna-m commented 3 years ago

Recently, enableExternalNameService is default being set to false to mitigate https://github.com/kubernetes/kubernetes/issues/103675. This is creating a breaking change for Knative. It would be nice to be able to use the operator which we use in our Knative serving e2e tests to override this for now, until we move forward with one of the paths below.

For more context https://github.com/knative/serving/issues/11821.

youngnick commented 3 years ago

I think this is fair, we should do this.