search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

use GHCR image by default #439

Closed skriss closed 3 years ago

skriss commented 3 years ago

Updates examples, CI and docs to use the GHCR image by default. The Docker Hub image will continue to be pushed for the time being to help migration.

Signed-off-by: Steve Kriss krisss@vmware.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #439 (03cb00c) into main (c868e32) will increase coverage by 0.49%. The diff coverage is n/a.

:exclamation: Current head 03cb00c differs from pull request most recent head acde28d. Consider uploading reports for the commit acde28d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   76.64%   77.14%   +0.49%     
==========================================
  Files          29       29              
  Lines        2231     2231              
==========================================
+ Hits         1710     1721      +11     
+ Misses        381      376       -5     
+ Partials      140      134       -6
Impacted Files Coverage Δ
internal/config/config.go 100.00% <ø> (ø)
internal/status/status.go 48.64% <0.00%> (-2.71%) :arrow_down:
internal/objects/service/service.go 84.34% <0.00%> (+0.86%) :arrow_up:
internal/controller/controller.go 74.59% <0.00%> (+8.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c868e32...acde28d. Read the comment docs.

skriss commented 3 years ago

Problems with the upgrade test since it's just manipulating the image tag (so looking for ghcr.io/projectcontour/contour-operator:latest, rather than applying full manifests from the previous released version which would set the image to the DockerHub latest. If we manually push some previous releases into GHCR including the latest tag then this should be able to pass.

youngnick commented 3 years ago

If we manually push some previous releases into GHCR including the latest tag then this should be able to pass.

I think we (well, you :) ) should do this without delay, since it's a one-off, and images not used on Docker Hub will be removed after 6 months.

skriss commented 3 years ago

If we manually push some previous releases into GHCR including the latest tag then this should be able to pass.

I think we (well, you :) ) should do this without delay, since it's a one-off, and images not used on Docker Hub will be removed after 6 months.

Will get this done today for both contour and operator.

skriss commented 3 years ago

@stevesloka could you take a quick look at this one when you get a chance? Thanks!