search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

Add option to configure `enableExternalNameService` in Contour CRD #445

Closed nak3 closed 2 years ago

nak3 commented 2 years ago

This patch adds enableExternalNameService option to Contour CRD to enable/disable it.

Fixes https://github.com/projectcontour/contour-operator/issues/437

Signed-off-by: Kenjiro Nakayama nakayamakenjiro@gmail.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #445 (e881233) into main (6d02976) will decrease coverage by 2.02%. The diff coverage is 50.00%.

:exclamation: Current head e881233 differs from pull request most recent head c09ed80. Consider uploading reports for the commit c09ed80 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   79.91%   77.89%   -2.03%     
==========================================
  Files          29       29              
  Lines        2231     2235       +4     
==========================================
- Hits         1783     1741      -42     
- Misses        331      362      +31     
- Partials      117      132      +15
Impacted Files Coverage Δ
internal/objects/contour/contour.go 76.62% <0.00%> (-7.38%) :arrow_down:
internal/objects/configmap/configmap.go 74.68% <100.00%> (-1.94%) :arrow_down:
internal/status/status.go 48.64% <0.00%> (-16.22%) :arrow_down:
internal/controller/controller.go 72.13% <0.00%> (-8.20%) :arrow_down:
internal/objects/rbac.go 60.71% <0.00%> (-3.58%) :arrow_down:
internal/objects/job/job.go 79.13% <0.00%> (-2.61%) :arrow_down:
internal/objects/service/service.go 86.08% <0.00%> (-2.61%) :arrow_down:
internal/objects/deployment/deployment.go 93.22% <0.00%> (-2.55%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d02976...c09ed80. Read the comment docs.