search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

Update Contour CRDs #446

Closed youngnick closed 2 years ago

youngnick commented 2 years ago

Signed-off-by: Nick Young ynick@vmware.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #446 (e0134dd) into main (2cd982b) will decrease coverage by 2.86%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   80.08%   77.22%   -2.87%     
==========================================
  Files          29       29              
  Lines        2235     2235              
==========================================
- Hits         1790     1726      -64     
- Misses        328      374      +46     
- Partials      117      135      +18
Impacted Files Coverage Δ
internal/objects/contour/finalizer.go 62.50% <0.00%> (-18.75%) :arrow_down:
internal/status/status.go 56.75% <0.00%> (-16.22%) :arrow_down:
internal/objects/rbac.go 54.76% <0.00%> (-9.53%) :arrow_down:
internal/controller/controller.go 74.59% <0.00%> (-8.20%) :arrow_down:
internal/objects/configmap/configmap.go 70.88% <0.00%> (-6.33%) :arrow_down:
internal/objects/job/job.go 76.52% <0.00%> (-5.22%) :arrow_down:
internal/objects/contour/contour.go 76.62% <0.00%> (-5.20%) :arrow_down:
internal/objects/service/service.go 84.34% <0.00%> (-4.35%) :arrow_down:
internal/objects/daemonset/daemonset.go 93.21% <0.00%> (-2.50%) :arrow_down:
internal/objects/deployment/deployment.go 91.94% <0.00%> (-2.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cd982b...e0134dd. Read the comment docs.

skriss commented 2 years ago

This is still failing codegen, not sure why all the line wrap changes to operator.yaml

sunjayBhatia commented 2 years ago

This is still failing codegen, not sure why all the line wrap changes to operator.yaml

Maybe old versions of tools?

youngnick commented 2 years ago

I think that was it, kustomize version was different on my machine. Sigh.

youngnick commented 2 years ago

Okay, I'm going to merge this one using admin powers since it's just the codecov check failing. This should clear up the scheduled CI failures.