Codecov Report

Merging #453 (1475c1c) into main (2bbc2d3) will decrease coverage by 3.29%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   80.52%   77.22%   -3.30%     
==========================================
  Files          29       29              
  Lines        2213     2213              
==========================================
- Hits         1782     1709      -73     
- Misses        310      363      +53     
- Partials      121      141      +20

Impacted Files	Coverage Δ
internal/objects/daemonset/daemonset.go	`93.21% <100.00%> (-1.79%)`	:arrow_down:
internal/status/status.go	`43.24% <0.00%> (-29.73%)`	:arrow_down:
internal/controller/controller.go	`66.39% <0.00%> (-13.94%)`	:arrow_down:
internal/objects/rbac.go	`54.76% <0.00%> (-9.53%)`	:arrow_down:
internal/objects/configmap/configmap.go	`70.88% <0.00%> (-6.33%)`	:arrow_down:
internal/objects/job/job.go	`76.52% <0.00%> (-5.22%)`	:arrow_down:
internal/objects/service/service.go	`83.47% <0.00%> (-5.22%)`	:arrow_down:
internal/objects/contour/contour.go	`76.62% <0.00%> (-5.20%)`	:arrow_down:
internal/objects/deployment/deployment.go	`91.94% <0.00%> (-2.12%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bbc2d3...1475c1c. Read the comment docs.

skriss commented 2 years ago

Moved this to 1.20

tsaarni commented 2 years ago

maybe add a test to https://github.com/projectcontour/contour-operator/blob/5b48940f9f4aaea57e0441ea4859aa6b5dcbe19b/internal/objects/daemonset/daemonset_test.go

I added SecurityContext to be covered by the daemonset test case.

projectcontour / contour-operator

Added securityContext to run Envoy as non-root. #453

Codecov Report