projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

fixup CRDs from Contour & resolve linting errors #476

Closed stevesloka closed 2 years ago

stevesloka commented 2 years ago

Signed-off-by: Steve Sloka slokas@vmware.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #476 (472d531) into main (178300a) will decrease coverage by 1.81%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   80.76%   78.94%   -1.82%     
==========================================
  Files          29       29              
  Lines        2209     2209              
==========================================
- Hits         1784     1744      -40     
- Misses        307      337      +30     
- Partials      118      128      +10     
Impacted Files Coverage Δ
internal/status/status.go 48.64% <0.00%> (-24.33%) :arrow_down:
internal/controller/controller.go 74.59% <0.00%> (-5.74%) :arrow_down:
internal/objects/contour/contour.go 76.62% <0.00%> (-5.20%) :arrow_down:
internal/objects/rbac.go 60.71% <0.00%> (-3.58%) :arrow_down:
internal/objects/job/job.go 79.13% <0.00%> (-2.61%) :arrow_down:
internal/objects/deployment/deployment.go 93.22% <0.00%> (-2.55%) :arrow_down:
internal/objects/configmap/configmap.go 74.68% <0.00%> (-2.54%) :arrow_down:
internal/objects/service/service.go 86.95% <0.00%> (-1.74%) :arrow_down:
internal/objects/daemonset/daemonset.go 95.00% <0.00%> (-0.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 178300a...472d531. Read the comment docs.

skriss commented 2 years ago

Looks like a file is missing, make generate generate-contour-crds generate-gateway-crds manifests example is what I usually run (from prbuild.yaml's generate step)