search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

examples: move NodePort example to default namespace #478

Closed skriss closed 2 years ago

skriss commented 2 years ago

Puts the Contour CR for the NodePort examples into the default namespace to be consistent with other examples.

(This helps with updating the getting started guide, in https://github.com/projectcontour/contour/pull/4288).

Signed-off-by: Steve Kriss krisss@vmware.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #478 (b2918d8) into main (e264530) will decrease coverage by 3.80%. The diff coverage is n/a.

:exclamation: Current head b2918d8 differs from pull request most recent head afecdd4. Consider uploading reports for the commit afecdd4 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   81.12%   77.32%   -3.81%     
==========================================
  Files          29       29              
  Lines        2209     2209              
==========================================
- Hits         1792     1708      -84     
- Misses        303      360      +57     
- Partials      114      141      +27
Impacted Files Coverage Δ
internal/status/status.go 51.35% <0.00%> (-21.63%) :arrow_down:
internal/objects/contour/finalizer.go 62.50% <0.00%> (-18.75%) :arrow_down:
internal/controller/controller.go 66.39% <0.00%> (-16.40%) :arrow_down:
internal/objects/rbac.go 54.76% <0.00%> (-9.53%) :arrow_down:
internal/objects/job/job.go 76.52% <0.00%> (-6.96%) :arrow_down:
internal/objects/configmap/configmap.go 70.88% <0.00%> (-6.33%) :arrow_down:
internal/objects/service/service.go 83.47% <0.00%> (-5.22%) :arrow_down:
internal/objects/contour/contour.go 76.62% <0.00%> (-5.20%) :arrow_down:
internal/objects/deployment/deployment.go 91.94% <0.00%> (-3.82%) :arrow_down:
internal/objects/daemonset/daemonset.go 93.21% <0.00%> (-2.50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e264530...afecdd4. Read the comment docs.

skriss commented 2 years ago

Merging this in support of https://github.com/projectcontour/contour/pull/4288.