Bump Envoy to v1.21.0

[codecov[bot]]

Codecov Report

Merging #479 (e17a4cc) into main (bc74bd0) will decrease coverage by 2.76%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   80.57%   77.81%   -2.77%     
==========================================
  Files          29       29              
  Lines        2209     2209              
==========================================
- Hits         1780     1719      -61     
- Misses        309      355      +46     
- Partials      120      135      +15     

Impacted Files	Coverage Δ
internal/config/config.go	100.00% <ø> (ø)
internal/status/status.go	48.64% <0.00%> (-24.33%)	:arrow_down:
internal/objects/rbac.go	54.76% <0.00%> (-9.53%)	:arrow_down:
internal/objects/configmap/configmap.go	70.88% <0.00%> (-6.33%)	:arrow_down:
internal/controller/controller.go	74.59% <0.00%> (-5.74%)	:arrow_down:
internal/objects/job/job.go	76.52% <0.00%> (-5.22%)	:arrow_down:
internal/objects/contour/contour.go	76.62% <0.00%> (-5.20%)	:arrow_down:
internal/objects/service/service.go	84.34% <0.00%> (-4.35%)	:arrow_down:
internal/objects/daemonset/daemonset.go	93.21% <0.00%> (-2.50%)	:arrow_down:
internal/objects/deployment/deployment.go	91.94% <0.00%> (-2.12%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc74bd0...e17a4cc. Read the comment docs.

[sunjayBhatia]

Really poor test coverage on this one :trollface:

idk what's wrong with our codecov config that's causing the reports to look like this.

huh, some of the tests that contribute to coverage are the ones that use the controller-runtime test manager etc. (https://github.com/projectcontour/contour-operator/blob/main/internal/operator/operator_test.go), they seem to pass but maybe some variability in what parts of the controller logic gets hit? I'm pretty confused though on this one since its across so many files, all reduced coverage

[skriss]

Really poor test coverage on this one :trollface: idk what's wrong with our codecov config that's causing the reports to look like this.

huh, some of the tests that contribute to coverage are the ones that use the controller-runtime test manager etc. (https://github.com/projectcontour/contour-operator/blob/main/internal/operator/operator_test.go), they seem to pass but maybe some variability in what parts of the controller logic gets hit? I'm pretty confused though on this one since its across so many files, all reduced coverage

It almost seems like it's diffing against some old version of the operator, but I'm not sure.

[sunjayBhatia]

will open an issue on coverage, something to investigate