search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

sync Contour ClusterRole rules with Contour's #487

Closed skriss closed 2 years ago

skriss commented 2 years ago
skriss commented 2 years ago

Ah yes, forgot that dropping RBAC breaks the upgrade test due to https://github.com/projectcontour/contour-operator/issues/438.

codecov[bot] commented 2 years ago

Codecov Report

Merging #487 (11e0acf) into main (8529acb) will decrease coverage by 0.39%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   77.82%   77.43%   -0.40%     
==========================================
  Files          29       29              
  Lines        2210     2167      -43     
==========================================
- Hits         1720     1678      -42     
- Misses        352      354       +2     
+ Partials      138      135       -3
Impacted Files Coverage Δ
internal/operator/operator.go 77.77% <ø> (ø)
internal/objects/clusterrole/cluster_role.go 83.07% <100.00%> (-6.74%) :arrow_down:
internal/status/status.go 48.64% <0.00%> (-10.82%) :arrow_down:
internal/objects/service/service.go 84.34% <0.00%> (+0.86%) :arrow_up:
internal/controller/controller.go 74.59% <0.00%> (+2.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8529acb...11e0acf. Read the comment docs.

skriss commented 2 years ago

Ah yes, forgot that dropping RBAC breaks the upgrade test due to #438.

Disabled it again for now, will try to find time to work on fixing #438 so we don't have to keep doing this.

sunjayBhatia commented 2 years ago

thanks for including that removal in this 👍🏽