search

projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

internal/objects: simplify DesiredEnvoyService code #490

Closed skriss closed 2 years ago

skriss commented 2 years ago

Minor refactor to simplify DesiredEnvoyService function's code.

Signed-off-by: Steve Kriss krisss@vmware.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #490 (ad298db) into main (a343ed2) will decrease coverage by 1.56%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   79.00%   77.43%   -1.57%     
==========================================
  Files          29       29              
  Lines        2167     2167              
==========================================
- Hits         1712     1678      -34     
- Misses        328      351      +23     
- Partials      127      138      +11
Impacted Files Coverage Δ
internal/objects/service/service.go 84.34% <100.00%> (-2.61%) :arrow_down:
internal/status/status.go 56.75% <0.00%> (-16.22%) :arrow_down:
internal/objects/rbac.go 54.76% <0.00%> (-5.96%) :arrow_down:
internal/objects/configmap/configmap.go 70.88% <0.00%> (-3.80%) :arrow_down:
internal/objects/job/job.go 76.92% <0.00%> (-2.57%) :arrow_down:
internal/controller/controller.go 72.13% <0.00%> (-2.46%) :arrow_down:
internal/objects/daemonset/daemonset.go 93.21% <0.00%> (-1.79%) :arrow_down:
internal/objects/deployment/deployment.go 91.94% <0.00%> (-1.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a343ed2...ad298db. Read the comment docs.