projectcontour / contour-operator

Experimental repository to explore an operator for deploying Contour
Apache License 2.0
43 stars 34 forks source link

Bump Go to 1.19.4 #571

Closed sunjayBhatia closed 1 year ago

sunjayBhatia commented 1 year ago

Also bumps golang.org/x/net to v0.4.0 and gets rid of usage of pointer functions for primitive types in favor of generic based helper

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.22% // Head: 74.83% // Decreases project coverage by -1.38% :warning:

Coverage data is based on head (0a5c2ea) compared to base (fdccd56). Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #571 +/- ## ========================================== - Coverage 76.22% 74.83% -1.39% ========================================== Files 29 29 Lines 2625 2635 +10 ========================================== - Hits 2001 1972 -29 - Misses 487 519 +32 - Partials 137 144 +7 ``` | [Impacted Files](https://codecov.io/gh/projectcontour/contour-operator/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour) | Coverage Δ | | |---|---|---| | [internal/status/conditions.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvc3RhdHVzL2NvbmRpdGlvbnMuZ28=) | `66.33% <60.00%> (-1.06%)` | :arrow_down: | | [internal/objects/contour/contour.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvb2JqZWN0cy9jb250b3VyL2NvbnRvdXIuZ28=) | `73.40% <100.00%> (-6.39%)` | :arrow_down: | | [internal/objects/daemonset/daemonset.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvb2JqZWN0cy9kYWVtb25zZXQvZGFlbW9uc2V0Lmdv) | `92.21% <100.00%> (-0.63%)` | :arrow_down: | | [internal/objects/deployment/deployment.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvb2JqZWN0cy9kZXBsb3ltZW50L2RlcGxveW1lbnQuZ28=) | `90.61% <100.00%> (-0.73%)` | :arrow_down: | | [internal/objects/job/job.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvb2JqZWN0cy9qb2Ivam9iLmdv) | `76.02% <100.00%> (-2.74%)` | :arrow_down: | | [internal/ref/ref.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvcmVmL3JlZi5nbw==) | `100.00% <100.00%> (ø)` | | | [internal/status/status.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvc3RhdHVzL3N0YXR1cy5nbw==) | `45.83% <0.00%> (-8.34%)` | :arrow_down: | | [internal/controller/controller.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvY29udHJvbGxlci9jb250cm9sbGVyLmdv) | `67.33% <0.00%> (-4.67%)` | :arrow_down: | | [internal/objects/rbac.go](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour#diff-aW50ZXJuYWwvb2JqZWN0cy9yYmFjLmdv) | `51.81% <0.00%> (-3.64%)` | :arrow_down: | | ... and [5 more](https://codecov.io/gh/projectcontour/contour-operator/pull/571/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectcontour)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sunjayBhatia commented 1 year ago

probably blocked on https://github.com/projectcontour/contour-operator/pull/570

sunjayBhatia commented 1 year ago

taking a look again at that status package, do not merge for now!

sunjayBhatia commented 1 year ago

taking a look again at that status package, do not merge for now!

done