Closed skriss closed 1 year ago
Hmm, not sure why this is still showing a CRD error when running envtest-based tests, but not when running in kind clusters..
In light of #574, I opted to just disable the envtest-based tests rather than mucking around with kubebuilder versions/etc. since the tests are likely pretty redundant with E2E's anyway
Base: 75.21% // Head: 49.63% // Decreases project coverage by -25.57%
:warning:
Coverage data is based on head (
7189e7a
) compared to base (e991cb9
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
could the issue be a tools version? envtest etc. is probably pretty out of date here and on my dev machine currently
cool with dropping the tests since yeah we're planning on stopping supporting this anyways (and code hasn't changed tbh)
could the issue be a tools version? envtest etc. is probably pretty out of date here and on my dev machine currently
cool with dropping the tests since yeah we're planning on stopping supporting this anyways (and code hasn't changed tbh)
Yeah my best guess is it's due to an old envtest/associated binaries, but updating to kubebuilder v3 to get newer versions is not super-straightforward and I didn't see the point of going down that road. I think as long as we have the E2E's working we still have decent confidence here.
Signed-off-by: Steve Kriss krisss@vmware.com