Support Service AppProtocol field

projectcontour / contour

Contour is a Kubernetes ingress controller using Envoy proxy.

https://projectcontour.io

Apache License 2.0

3.68k stars 669 forks source link

Support Service AppProtocol field #2431

Open jpeach opened 4 years ago

jpeach commented 4 years ago

Kubernetes 1.8 adds an appProtocol field to the Service. This is an optional feature that is enabled with the ServiceAppProtocol feature gate.

We already support this concept in a Contour-specific way, so we should support this standard field in Contour too. We need to be careful how we resolve this against the equivalent field in labels and HTTPProxy.

davinkevin commented 1 year ago

This parameter is now globally available in kubernetes v1.20+, is this planned to be integrated into Contour?

Thank you 👍

github-actions[bot] commented 5 months ago

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

Mark this Issue as fresh by commenting
Close this Issue
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

davinkevin commented 5 months ago

With GatewayAPI, it's now integrated, no?

sunjayBhatia commented 5 months ago

Yes, as of 1.28.0+ Contour supports backend protocol selection with Gateway API: https://github.com/projectcontour/contour/blob/main/changelogs/CHANGELOG-v1.28.0.md#gateway-api-backend-protocol-selection

sunjayBhatia commented 5 months ago

Depending on interest in this for HTTPProxy, we may want to keep this around

It should be a relatively simple contribution to add the same logic in the HTTPProxy processor

lubronzhan commented 4 months ago

Cool I can help on this while waiting for the review for other PR

github-actions[bot] commented 2 months ago

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

Mark this Issue as fresh by commenting
Close this Issue
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] commented 3 weeks ago

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

Mark this Issue as fresh by commenting
Close this Issue
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

davinkevin commented 2 weeks ago

up?