Update defaults for guidelines on Configuring Envoy as an Edge Proxy

projectcontour / contour

Contour is a Kubernetes ingress controller using Envoy proxy.

https://projectcontour.io

Apache License 2.0

3.72k stars 678 forks source link

Update defaults for guidelines on Configuring Envoy as an Edge Proxy #4717

Open sunjayBhatia opened 2 years ago

sunjayBhatia commented 2 years ago

Envoy provides documentation guidelines on Configuring Envoy as an edge proxy

Contour has implemented some of these guidelines, but we should do another pass to make sure we have covered it all, for proxying TLS/TCP, HTTP/1.1, HTTP/2, etc.

There may be duplicates of this issue that can be linked, closed, etc. as needed

Tasks:

[ ] Add documentation linking to Envoy guidelines above: https://github.com/projectcontour/contour/issues/5046

github-actions[bot] commented 1 year ago

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

Mark this Issue as fresh by commenting
Close this Issue
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

sunjayBhatia commented 1 year ago

Seems still valuable to do, unstaling

github-actions[bot] commented 1 year ago

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

Mark this Issue as fresh by commenting
Close this Issue
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

Daxcor69 commented 1 year ago

Can you provide a way to make these changes? I am trying to find out where to make these changes..

sunjayBhatia commented 1 year ago

Can you provide a way to make these changes? I am trying to find out where to make these changes..

This will require code changes to Contour to configure Envoy with some of these values

Daxcor69 commented 1 year ago

Is this not what contour is, making envoy an edge proxy not a service mesh? Why would these values not be exposed by default?

sunjayBhatia commented 1 year ago

Contour does not aim to make every envoy configuration knob available to users to configure, this issue and the linked Envoy guidelines are for sensible defaults that we should apply, which involve code changes to Contour so the xDS server can send them to Envoy. Some values may additionally be exposed as user configurable, but that again involves code changes to Contour to expose those in an API and to send that configuration to Envoy.