projectcontour / contour

Contour is a Kubernetes ingress controller using Envoy proxy.
https://projectcontour.io
Apache License 2.0
3.72k stars 677 forks source link

Envoy FIPS build doesn't produce tarball #5411

Closed kyle-ntx closed 1 year ago

kyle-ntx commented 1 year ago

What question do you have?: I've been attempting to follow the instructions on the FIPS 140-2 in Contour documentation page, however, I am struggling to create the envoy_binary.tar.gz file mentioned in the section about building Envoy.

When I run the command BAZEL_BUILD_EXTRA_OPTIONS="--define boringssl=fips" ENVOY_DOCKER_BUILD_DIR=~/envoyBuild ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.release.server_only' from within the envoy directory (created by git cloning the envoy repo), the build appears to run without error, however, it does not produce the expected tar file.

When I look in the specified ENVOY_DOCKER_BUILD_DIR directory, I find 3 folders: bazel_root, envoy, repository_cache. Digging down into the 'envoy' folder I eventually find an executable called 'envoy' and another called envoy.dwp. They are found at this path: /envoyBuild/envoy/x64/source/exe/envoy

Does anyone have any idea what I am doing wrong here? My gut feeling on this is that either I've missed something obvious or the Envoy build process has changed and the command supplied in the documentation no longer works the way it used to.

Environment:

github-actions[bot] commented 1 year ago

Hey @kyle-ntx! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

sunjayBhatia commented 1 year ago

Yep the build process in Envoy has changed so our doc needs a bit of an update, we can use this issue to track making the updates

sunjayBhatia commented 1 year ago

Take a look at the update in https://github.com/projectcontour/contour/pull/5415 to see if it works! Would appreciate any comments in case you run into any issues

kyle-ntx commented 1 year ago

Thanks for the super fast response! I've taken a look at the PR and left a comment.